Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.5] Mark Navigation/Navigation2D nodes as deprecated #62187

Merged
merged 1 commit into from
Jun 20, 2022
Merged

[3.5] Mark Navigation/Navigation2D nodes as deprecated #62187

merged 1 commit into from
Jun 20, 2022
+18 −0

Conversation

smix8
Copy link
Contributor

@smix8 smix8 commented Jun 19, 2022 •
edited
Loading

Mark Navigation/Navigation2D nodes as deprecated. They already just redirect calls to the NavigationServer and have no longer a real purpose. In Godot 4.0 both nodes are already removed for good reasons outlined here #46786 or discussed here #691

@smix8 smix8 requested review from a team as code owners June 19, 2022 00:01
@smix8 smix8 force-pushed the nav_nodes_depr_3.5 branch 2 times, most recently from 7dc2725 to 73371fd Compare June 19, 2022 00:14
@akien-mga akien-mga added this to the 3.5 milestone Jun 20, 2022
akien-mga
akien-mga reviewed Jun 20, 2022
View reviewed changes
scene/3d/navigation.cpp Outdated Show resolved Hide resolved
akien-mga
akien-mga reviewed Jun 20, 2022
View reviewed changes
scene/3d/navigation.cpp Outdated Show resolved Hide resolved
@smix8
[3.5] Mark Navigation/Navigation2D nodes as deprecated
693aeaf 
Mark Navigation/Navigation2D nodes as deprecated. They already just redirect calls to the NavigationServer and have no longer a real purpose. In Godot 4.0 both nodes are already removed for good reasons.
@akien-mga akien-mga merged commit 3c35617 into godotengine:3.x Jun 20, 2022
@akien-mga
Copy link
Member

Thanks!

@smix8 smix8 deleted the nav_nodes_depr_3.5 branch June 20, 2022 16:44
@Flavelius
Copy link
Contributor

In 3.5rc5 i tried using only NavmeshInstance and direct server calls, but it seems that's not possible as something in the NavmeshInstance node still expects there to be a Navigation node; atleast that's what i gathered by looking at the source (i'm not very versed in c++) when it didn't work for me, and i also tried replicating everything that seemed logical from the Navigation node source code.
Can you confirm that the deprecation actually means there's a way to make it work without the Navigation node in 3.5?

@smix8
Copy link
Contributor Author

smix8 commented Jul 23, 2022

@Flavelius
The NavigationMeshInstance node uses the default navigation map of the Viewport world object from get_world()->get_navigation_map() if no Navigation node is found.

You can also make updates with the NavigationServer API directly should any of the navigation related nodes bug out for whatever reason. If you cannot make it work might want to open a dedicated issue for it.

@Gralios
Copy link

Gralios commented Oct 30, 2022

There is no example in assets ? I'm very confused by this new change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:navigation
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
4 participants
@smix8 @akien-mga @Flavelius @Gralios